Add mypy #167
Open
Add mypy #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisRayM
force-pushed
the
151-add-mypy
branch
2 times, most recently
from
702e150
to
7bf6f9e
Compare
moshthepitt
reviewed
Jan 23, 2020
setup.cfg
Outdated
Comment on lines
16
to
26
|
|
||
| [mypy-django.*] | ||
| ignore_missing_imports = True | ||
|
|
||
| [mypy-django_countries.*] | ||
| ignore_missing_imports = True | ||
|
|
||
| [mypy-django_filters.*] | ||
| ignore_missing_imports = True | ||
|
|
||
| [mypy-mptt.*] | ||
| ignore_missing_imports = True | ||
|
|
||
| [mypy-rest_framework.*] | ||
| ignore_missing_imports = True | ||
|
|
||
| [mypy-rest_framework_gis.*] | ||
| ignore_missing_imports = True |
There was a problem hiding this comment.
why are these necessary?
There was a problem hiding this comment.
mypy raises import errors for third party packages that it cannot find, had to silence them so that they do not cause the checks to fail.
There was a problem hiding this comment.
Hmmm, I am hesitant about this - because I am strongly against relaxing linting rules. Some questions:
- why cant mypy find these packages (I ask this because I have used it elsewhere and not gotten into this problem)?
There was a problem hiding this comment.
Hmmm, I am hesitant about this - because I am strongly against relaxing linting rules. Some questions:
* why cant mypy find these packages (I ask this because I have used it elsewhere and not gotten into this problem)?
Seems like this was just a blunder on my side. Was running it outside of my virtualenv.
After running it in the virtualenv it doesn't seem to raise any errors without the config. I'll make the change.
DavisRayM
force-pushed
the
151-add-mypy
branch
from
7bf6f9e
to
aa7a982
Compare
moshthepitt
approved these changes
Jan 24, 2020
DavisRayM
force-pushed
the
151-add-mypy
branch
from
aa7a982
to
961d786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Steps taken to verify this change does what is intended
Side effects of implementing this change
Closes #151