Refactoring code for eslint, test and typo #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files from running cli - yarn set version 3.4.1 - yarn
|
I appreciate your work. I'm getting a yarn build error in CI, please check it out. Also, please change the target brunch to develop. |
jinoosss
reviewed
Dec 4, 2023
packages/adena-extension/src/services/transaction/transaction-history.ts
Outdated
Show resolved
Hide resolved
packages/adena-extension/src/containers/approve-sign-container/approve-sign-container.tsx
Outdated
Show resolved
Hide resolved
...ion/src/containers/approve-sign-transaction-container/approve-sign-transaction-container.tsx
Outdated
Show resolved
Hide resolved
...ena-extension/src/containers/approve-transaction-container/approve-transaction-container.tsx
Outdated
Show resolved
Hide resolved
packages/adena-extension/src/common/storage/chrome-local-storage.ts
Outdated
Show resolved
Hide resolved
.../components/approve/approve-adding-network/approve-adding-network/approve-adding-network.tsx
Show resolved
Hide resolved
This reverts commit 8693b7f.
jinoosss
approved these changes
Dec 5, 2023
dongwon8247
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.