Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor container & layout #320

Merged
merged 7 commits into from
Dec 20, 2023
Merged

Refactor container & layout #320

merged 7 commits into from
Dec 20, 2023

Conversation

skqksh
Copy link
Collaborator

@skqksh skqksh commented Dec 18, 2023

  • Move containers and layout to related page or components folder
  • Classify components as atoms, molecules, or pages.
  • Move container code to the index file

remained to refactor items

  • Separating container logic to hook

dongwon8247
dongwon8247 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@dongwon8247 dongwon8247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with @jinoosss. Well done!

@dongwon8247 dongwon8247 merged commit f75451e into onbloc:main Dec 20, 2023
2 checks passed
@skqksh skqksh deleted the main branch December 21, 2023 11:12
@dongwon8247 dongwon8247 mentioned this pull request Jan 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongwon8247 dongwon8247 dongwon8247 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skqksh @dongwon8247