-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor css, components #321
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9309800
refactor. Separate secure-textarea and improve attributes in SeedBox …
skqksh 63acdb4
refactor. export private key screen
skqksh 119d2b0
refactor. remove unused code
skqksh d03c09c
refactor. simplify css
skqksh 2ef6bc0
refactor. change enum to type for button hierarchy attribute
skqksh 1890f53
refactor. use theme from provider. seperate font and mixins from theme
skqksh 0fde8af
fix. tx history list item font size
skqksh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 8 additions & 7 deletions
15
packages/adena-extension/src/components/atoms/default-input/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,27 @@ | ||
import styled, { FlattenSimpleInterpolation, css } from 'styled-components'; | ||
import styled, { css } from 'styled-components'; | ||
|
||
import { fonts, getTheme } from '@styles/theme'; | ||
|
||
interface InputProps { | ||
error?: boolean; | ||
margin?: string; | ||
} | ||
|
||
export const inputStyle = css` | ||
${({ theme }): FlattenSimpleInterpolation => theme.fonts.body2Reg}; | ||
${fonts.body2Reg}; | ||
width: 100%; | ||
height: 48px; | ||
background-color: ${({ theme }): string => theme.color.neutral[8]}; | ||
color: ${({ theme }): string => theme.color.neutral[0]}; | ||
background-color: ${getTheme('neutral', '_9')}; | ||
color: ${getTheme('neutral', '_1')}; | ||
border-radius: 30px; | ||
padding: 14px 16px; | ||
::placeholder { | ||
color: ${({ theme }): string => theme.color.neutral[9]}; | ||
color: ${getTheme('neutral', 'a')}; | ||
} | ||
`; | ||
|
||
export const DefaultInput = styled.input<InputProps>` | ||
${inputStyle}; | ||
border: 1px solid | ||
${({ error, theme }): string => (error ? theme.color.red[2] : theme.color.neutral[6])}; | ||
border: 1px solid ${({ error, theme }): string => (error ? theme.red._5 : theme.neutral._7)}; | ||
margin: ${({ margin }): string | undefined => margin && margin}; | ||
`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this theme static data?
Even if you have one current theme, it seems like a good idea to use the theme injected by the theme provider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure