feat: [ADN-335] Apply tm2-js-client for creating wallets #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skqksh
reviewed
Jan 10, 2024
| @@ -110,6 +111,10 @@ const SideMenuContainer: React.FC<SideMenuContainerProps> = ({ open, setOpen }) | |||
| setOpen(false); | |||
| }, [setOpen]); | |||
|
|
|||
| useEffect(() => { | |||
| getSideMenuAccounts().then(setSideMenuAccounts); | |||
| }, [getSideMenuAccounts]); | |||
There was a problem hiding this comment.
why don't we use useQuery instead of useEffect
// e.g
const { data: sideMenuAccounts = [] } = useQuery<SideMenuAccountInfo[]>(
['sideMenuAccounts', accountNames, accounts, accountNativeBalances, currentNetwork],
() => {
function mapBalance(
accountNativeBalances: { [key in string]: TokenBalanceType },
account: Account,
): string {
const amount = accountNativeBalances[account.id]?.amount;
if (!amount) {
return '-';
}
return `${maxFractionDigits(amount.value, 6)} ${amount.denom}`;
}
return Promise.all(
accounts.map(async (account) => ({
accountId: account.id,
name: formatNickname(accountNames[account.id] || account.name, 10),
address: await account.getAddress(currentNetwork.addressPrefix),
type: account.type,
balance: mapBalance(accountNativeBalances, account),
})),
);
},
{
enabled: !locked && accounts.length > 0 && !!currentNetwork,
},
);
There was a problem hiding this comment.
This is nice and clear 👍.
jinoosss
force-pushed
the
ADN-335-apply-tm-2-js-client-for-creating-wallets
branch
from
b32c1ba
to
a13d7b5
Compare
skqksh
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.