feat: Define and create new handler for new vm_noop message type
#540
Conversation
| @@ -1,5 +1,5 @@ | |||
| import { Any, PubKeySecp256k1, Tx, TxFee, TxSignature } from '@gnolang/tm2-js-client'; | |||
| import { MsgCall, MsgAddPackage, MsgSend, MsgEndpoint } from '@gnolang/gno-js-client'; | |||
| import { MsgCall, MsgAddPackage, MsgSend, MsgEndpoint, MsgNoop } from '@gnolang/gno-js-client'; | |||
There was a problem hiding this comment.
Is there a link to see what MsgNoop looks like?
There was a problem hiding this comment.
Yes, I can guess from the modifications in the gno chain.
But I wanted to check out decoding the proto in gno-js-client.
https://github.com/onbloc/adena-wallet/pull/540/files#diff-ebc97186e74851cee33a3481a356d0f5e231df2e90af1ccaf35ea14cc9fb461aR63-R64
There was a problem hiding this comment.
sorry for this lately response, it was in pending state, I did not commited the comments
@jinoosss
I think this PR about our changes in gno-js-client may fit.
gnolang/gno-js-client#140
I will update later for further information.
| if (document?.msgs[0].type === '/vm.m_noop') { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
You need to check for multi-messages.
Additionally, it would be nice to have a separate type-checking function for this.
There was a problem hiding this comment.
we separate type-checking function and add condition to check for multi-messages.
There was a problem hiding this comment.
the changes address at 764ad3e
What type of PR is this?
What this PR does:
In the view of sponsor feature, this PR aims to:
We are now using our version of
gno, tm2-js-client`, ... and will update to make this PR ready after these PRs are merged.Read more about
sponsor-serviceat:updating...