-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a feature to manually add custom tokens #604
feat: add a feature to manually add custom tokens #604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locally tested, mostly works well, but minor fixes needed:
- When a token path is long, such as
gno.land/r/g146gxysfx24t3nar4z4yzkca2g8u9vl8xlpmtq0/tuna
, it doesn't detect the token. - Some tokens, such as
gno.land/r/onbloc/foo
, had a 5-6 second loading time when adding them. - When I manually add a token that I've already added, it still adds even if it's already added. If it's been added already, then can we show "Already added" in the error message?
- Can you make the three small loading bars blink? like the main page's loading bars.
- We talked about Adena automatically detecting tokens and adding them when there's balance. Do you want to work on this on a separate PR? up to you.
@dongwon8247 , And I think detecting and adding tokens with balance should be a separate task. |
…-to-manually-add-custom-tokens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What type of PR is this?
What this PR does:
Change to allow GRC20 tokens to be added manually.
Call the RPC directly for the presence of tokens, rather than a list of tokens fetched from the tx-indexer.