Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a feature to manually add custom tokens #604

Merged
merged 9 commits into from
Oct 25, 2024

Conversation

jinoosss
Copy link
Member

What type of PR is this?

  • feature

What this PR does:

Change to allow GRC20 tokens to be added manually.

Call the RPC directly for the presence of tokens, rather than a list of tokens fetched from the tx-indexer.

  • To determine if Adena is a token, we parse the result of GRC20's Render function for information.

@jinoosss jinoosss requested a review from a team as a code owner October 15, 2024 09:58
Copy link
Member

@dongwon8247 dongwon8247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally tested, mostly works well, but minor fixes needed:

  1. When a token path is long, such as gno.land/r/g146gxysfx24t3nar4z4yzkca2g8u9vl8xlpmtq0/tuna, it doesn't detect the token.
  2. Some tokens, such as gno.land/r/onbloc/foo, had a 5-6 second loading time when adding them.
  3. When I manually add a token that I've already added, it still adds even if it's already added. If it's been added already, then can we show "Already added" in the error message?
  4. Can you make the three small loading bars blink? like the main page's loading bars.
  5. We talked about Adena automatically detecting tokens and adding them when there's balance. Do you want to work on this on a separate PR? up to you.

@jinoosss
Copy link
Member Author

jinoosss commented Oct 16, 2024

@dongwon8247 ,
Thanks for the review.
I'll take a look at the contents.

And I think detecting and adding tokens with balance should be a separate task.

Copy link
Member

@dongwon8247 dongwon8247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jinoosss jinoosss merged commit d178cd9 into main Oct 25, 2024
2 checks passed
@jinoosss jinoosss deleted the ADN-510-add-a-feature-to-manually-add-custom-tokens branch October 25, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants