Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a memo field #609

Merged
merged 8 commits into from
Oct 23, 2024
Merged

feat: add a memo field #609

merged 8 commits into from
Oct 23, 2024

Conversation

jinoosss
Copy link
Member

What type of PR is this?

  • feature

What this PR does:

  • When sending a token, we provide the ability to send a note along with it.
  • Provides the ability to edit or check notes when executing the Transaction Broadcast request method in the DApp.

@jinoosss jinoosss requested a review from a team as a code owner October 22, 2024 10:31
dongwon8247
dongwon8247 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@dongwon8247 dongwon8247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locally tested and it works great!

@jinoosss jinoosss merged commit d576c34 into main Oct 23, 2024
2 checks passed
@jinoosss jinoosss deleted the ADN-505-add-a-memo-field branch October 23, 2024 01:22
@dongwon8247 dongwon8247 mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongwon8247 dongwon8247 dongwon8247 approved these changes

@onlyhyde onlyhyde Awaiting requested review from onlyhyde onlyhyde is a code owner automatically assigned from onbloc/core-engineers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinoosss @dongwon8247