Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve mnemonic handling #685

Merged
merged 4 commits into from
Jan 30, 2025
Merged

feat: improve mnemonic handling #685

merged 4 commits into from
Jan 30, 2025

Conversation

jinoosss
Copy link
Member

What type of PR is this?

  • feature

What this PR does:

  • Store the mnemonic in your wallet as Entropy.

    • When you need a mnemonic, convert it from Entropy and use it.

  • When you show a mnemonic, it's drawn on the canvas.

@jinoosss jinoosss requested a review from a team as a code owner January 30, 2025 17:25
@jinoosss jinoosss merged commit 03747dd into main Jan 30, 2025
2 checks passed
@jinoosss jinoosss deleted the ADN-661-hal-008-critical-mnemonic-phrase-exposure-in-memory branch January 30, 2025 17:35
@jinoosss jinoosss mentioned this pull request Jan 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlyhyde onlyhyde Awaiting requested review from onlyhyde onlyhyde is a code owner automatically assigned from onbloc/core-engineers

@dongwon8247 dongwon8247 Awaiting requested review from dongwon8247 dongwon8247 is a code owner automatically assigned from onbloc/core-engineers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jinoosss