Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

FI-567: Add _include Medication test #408

Merged
merged 7 commits into from
Jan 15, 2020

Conversation

Jammjammjamm
Copy link
Contributor

@Jammjammjamm Jammjammjamm commented Jan 3, 2020

This branch adds a test for including Medications in MedicationRequest searches as described in the US Core Medication List Guidance.

Submitter:

  • This pull request describes why these changes were made
  • Internal ticket for this PR: https://oncprojectracking.healthit.gov/support/browse/FI-567
  • Internal ticket links to this PR
  • Internal ticket is properly labeled (Community/Program)
  • Internal ticket has a justification for its Community/Program label
  • Code diff has been reviewed for extraneous/missing code
  • Tests are included and test edge cases
  • Tests/code quality metrics have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@Jammjammjamm Jammjammjamm self-assigned this Jan 3, 2020
@Jammjammjamm Jammjammjamm force-pushed the fi-567-add-include-medication-test branch from 4faf412 to 224aa33 Compare January 3, 2020 18:47
@Jammjammjamm Jammjammjamm force-pushed the fi-567-add-include-medication-test branch from 224aa33 to 6a96329 Compare January 4, 2020 17:28
yunwwang
yunwwang previously approved these changes Jan 7, 2020
@Jammjammjamm Jammjammjamm dismissed yunwwang’s stale review January 15, 2020 14:56

PR has been completely redone

Copy link
Contributor

@arscan arscan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great on the reference server.

@arscan arscan merged commit cdec3c4 into development Jan 15, 2020
@arscan arscan deleted the fi-567-add-include-medication-test branch January 15, 2020 21:16
@radamson radamson mentioned this pull request Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants