Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Fi 581 do not skip on capability check when no capability statement loaded #409

Merged
merged 3 commits into from
Jan 3, 2020

Conversation

arscan
Copy link
Contributor

@arscan arscan commented Jan 3, 2020

When in community edition, running the profile tests will skip if you haven't first run the capability sequence. This doesn't make sense in the context of the community edition. Change so that if no capability statement is loaded, we do not skip, because we do not know if they support or do not support a capability.

Submitter:

  • This pull request describes why these changes were made
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Internal ticket is properly labeled (Community/Program)
  • Internal ticket has a justification for its Community/Program label
  • Code diff has been reviewed for extraneous/missing code
  • Tests are included and test edge cases
  • Tests/code quality metrics have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@Jammjammjamm Jammjammjamm changed the title Fi 580 do not skip on capability check when no capability statement loaded Fi 581 do not skip on capability check when no capability statement loaded Jan 3, 2020
@Jammjammjamm Jammjammjamm merged commit a712bf3 into development Jan 3, 2020
@Jammjammjamm Jammjammjamm deleted the fi-580-skip-capability branch January 3, 2020 20:30
@radamson radamson mentioned this pull request Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants