This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is there a reason why you don't do check_for_data_absent_reasons for multiple-or tests? |
That's just an oversight, thanks for bringing it up. |
Jammjammjamm
force-pushed
the
fi-582-dar-tests
branch
from
February 7, 2020 18:53
988cfe7
to
751a364
Compare
@czh-orz The multiple or tests now check for data absent reasons. |
Jammjammjamm
force-pushed
the
fi-582-dar-tests
branch
from
February 7, 2020 22:14
751a364
to
95a953b
Compare
arscan
force-pushed
the
fi-582-dar-tests
branch
from
February 10, 2020 02:44
95a953b
to
176f659
Compare
arscan
approved these changes
Feb 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Our data set generator doesn't support the CodeSystem one yet, but I think it should.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds tests for data absent reasons. It ties into
fetch_all_bundle_resources
andvalidate_read_reply
to search each retrieved resource for the data absent reason extension and the data absent reason code. TheTestingInstance
tracks whether each of these have been found, and then the actual data absent reason sequence just checks the values onTestingInstance
. As part of this branch I also added a way to include static files with the US Core generation.Submitter:
Reviewer 1:
Name:
where appropriate, and accomplishes the task's purpose
Reviewer 2:
Name:
where appropriate, and accomplishes the task's purpose