Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

FI-582: Data Absent Reason tests #432

Merged
merged 10 commits into from
Feb 10, 2020
Merged

FI-582: Data Absent Reason tests #432

merged 10 commits into from
Feb 10, 2020

Conversation

Jammjammjamm
Copy link
Contributor

This branch adds tests for data absent reasons. It ties into fetch_all_bundle_resources and validate_read_reply to search each retrieved resource for the data absent reason extension and the data absent reason code. The TestingInstance tracks whether each of these have been found, and then the actual data absent reason sequence just checks the values on TestingInstance. As part of this branch I also added a way to include static files with the US Core generation.

Submitter:

  • This pull request describes why these changes were made
  • Internal ticket for this PR: https://oncprojectracking.healthit.gov/support/browse/FI-582
  • Internal ticket links to this PR
  • Internal ticket is properly labeled (Community/Program)
  • Internal ticket has a justification for its Community/Program label
  • Code diff has been reviewed for extraneous/missing code
  • Tests are included and test edge cases
  • Tests/code quality metrics have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@Jammjammjamm Jammjammjamm self-assigned this Jan 30, 2020
@ghost
Copy link

ghost commented Feb 6, 2020

Is there a reason why you don't do check_for_data_absent_reasons for multiple-or tests?

@Jammjammjamm
Copy link
Contributor Author

That's just an oversight, thanks for bringing it up.

@Jammjammjamm
Copy link
Contributor Author

@czh-orz The multiple or tests now check for data absent reasons.

Copy link
Contributor

@arscan arscan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Our data set generator doesn't support the CodeSystem one yet, but I think it should.

@arscan arscan merged commit 7a37bcf into development Feb 10, 2020
@arscan arscan deleted the fi-582-dar-tests branch February 10, 2020 02:59
@radamson radamson mentioned this pull request Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants