Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

issue #444 - fix broken link #448

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Conversation

lmsurpre
Copy link
Contributor

@lmsurpre lmsurpre commented Apr 10, 2020

Pull requests into Inferno require the following items to be completed. Submitter and reviewer
should check the relevant check boxes when the associated item is done. For items that are not
applicable, note it's not applicable ("N/A") and check the box. For example, external Pull
Requests do not require ticket links.

Submitter:

  • This pull request describes why these changes were made
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Internal ticket is properly labeled (Community/Program)
  • Internal ticket has a justification for its Community/Program label
  • Code diff has been reviewed for extraneous/missing code
  • Tests are included and test edge cases
  • Tests/code quality metrics have been run locally and pass

All N/A, just fixing a broken link.

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@lmsurpre lmsurpre changed the title issue #44 - fix broken link issue #444 - fix broken link Apr 10, 2020
Copy link
Contributor

@radamson radamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for submitting the fix!

Addresses #444

@radamson radamson mentioned this pull request Apr 10, 2020
Copy link

@okeefm okeefm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too! Travis failure is not relevant to this branch.

@radamson radamson merged commit ad20a53 into onc-healthit:master Apr 22, 2020
@radamson radamson mentioned this pull request Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants