This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
FI-964 fix bugs with _id search parameter and .where in search validation #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
Jammjammjamm
approved these changes
Aug 21, 2020
| path.gsub(/.where\((.*)/, '') | ||
| end | ||
|
|
||
| def capitalize_first_letter(str) |
There was a problem hiding this comment.
I recently discovered that ActiveSupport has an upcase_first method that we can use for this https://api.rubyonrails.org/v5.2.4/classes/String.html#method-i-upcase_first
There was a problem hiding this comment.
Man, ActiveSupport has everything, doesn't it?
radamson
approved these changes
Sep 8, 2020
okeefm
approved these changes
Sep 8, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some bugs in the generic generator involving search parameters. One issue is that the search validation code used to have fhir path expressions that we couldn't handle. For example, the us core laboratory result sequence had the ".where" in the search validation code. This removes the ".where" part. The second is that the patient id parameter was being set to
idinstead of_id.To test, run the generic generator on the us core resources. Check that the patient sequence's id search is _id instead id and that the ".where" is not included in the lab result sequence.