Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

FI-957: Build .index.json for package tarball or upload standalone profiles #483

Merged
merged 26 commits into from
Sep 9, 2020

Conversation

jason-crowley
Copy link
Contributor

FI-957: This PR adds an IndexBuilder utility class to handle indexing IG packages (creating an .index.json at the root and for all subdirectories). It also POSTs profiles one-by-one to the validator if no package.json is present.

Submitter:

  • This pull request describes why these changes were made
  • Internal ticket for this PR: https://oncprojectracking.healthit.gov/support/browse/FI-957
  • Internal ticket links to this PR
  • Internal ticket is properly labeled (Community/Program)
  • Internal ticket has a justification for its Community/Program label
  • Code diff has been reviewed for extraneous/missing code
  • Tests are included and test edge cases
  • Tests/code quality metrics have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

lib/app/utils/index_builder.rb Outdated Show resolved Hide resolved
lib/app/utils/index_builder.rb Outdated Show resolved Hide resolved
lib/app/utils/index_builder.rb Outdated Show resolved Hide resolved
lib/app/utils/index_builder.rb Outdated Show resolved Hide resolved
lib/app/utils/startup_tasks.rb Outdated Show resolved Hide resolved
lib/app/utils/index_builder.rb Outdated Show resolved Hide resolved
jason-crowley and others added 2 commits August 26, 2020 08:59
Co-authored-by: Stephen MacVicar <Jammjammjamm@users.noreply.github.com>
Copy link
Contributor

@radamson radamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out and works well with:

  • just profiles
  • profiles and package.json
  • profiles, package.json and .index.json

Code looks good and clean too (thanks @Jammjammjamm and @jason-crowley!)

@radamson radamson merged commit bc27e5c into development Sep 9, 2020
@radamson radamson deleted the FI-957-index-builder branch September 9, 2020 19:22
@radamson radamson mentioned this pull request Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants