Created geneset in Genomic node #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhx828
reviewed
Sep 9, 2019
| curatedIsoform: string, | ||
| curatedRefSeq: string, | ||
| geneAliases: string[], | ||
| genesets: string[], |
There was a problem hiding this comment.
I don't think this type is correct and you should not include this property in Gene to prevent the circular references.
There was a problem hiding this comment.
Removed genesets in Gene model
| this.disableHugoSymbol = true; | ||
| this.selectedGenesetOption = _.find(this.genesetOptions, { id: this.genomicInput.geneset_id }); | ||
| this.genomicInput.hugo_symbol = this.selectedGenesetOption.genes.join(', '); | ||
| this.genomicInput.geneset = this.selectedGenesetOption.name; |
There was a problem hiding this comment.
If the name is updated, what's the process updating the name? Also if the geneset is updated(add/remove gene), what's the process?
There was a problem hiding this comment.
When a genomic node is initialized, I'll use the geneset_id stored in firebase to find the corresponding options pulled from OncoKB API (line 66 ~ 68). Even if a geneset name changed or its genes added or removed, the curation platform will always use its id to get latest data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix oncokb/oncokb#852, oncokb/oncokb#1796