Add role api #1046
Merged
Add role api #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bprize15
force-pushed
the
add-role-api
branch
from
d8bc09e to
db27360
Compare
zhx828
requested changes
Nov 9, 2023
src/main/java/org/mskcc/cbio/oncokb/web/rest/AccountResource.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mskcc/cbio/oncokb/web/rest/AccountResource.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mskcc/cbio/oncokb/web/rest/SlackController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mskcc/cbio/oncokb/web/rest/SlackController.java
Outdated
Show resolved
Hide resolved
bprize15
force-pushed
the
add-role-api
branch
from
db27360 to
a32aad3
Compare
bprize15
force-pushed
the
add-role-api
branch
3 times, most recently
from
1c408a4 to
6e7dcf6
Compare
calvinlu3
reviewed
Nov 21, 2023
src/main/java/org/mskcc/cbio/oncokb/service/dto/useradditionalinfo/ApiAccessRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mskcc/cbio/oncokb/web/rest/SlackController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mskcc/cbio/oncokb/web/rest/SlackController.java
Outdated
Show resolved
Hide resolved
src/main/webapp/app/components/newAccountForm/NewAccountForm.tsx
Outdated
Show resolved
Hide resolved
bprize15
force-pushed
the
add-role-api
branch
from
ef9c95b to
d320fa8
Compare
Added slack message for academic api access refactor api request for storing justification added request api endpoint & used on account page added slack approval process & api token generate added api approval email & change security for api added ROLE_API to user page and updated for tests edited new account form updated screenshot tests to test using role_api fixed screenshot test and updated new account form fixed screenshot test updated user details pages' screenshots add api mock data to get response added role api for academic users & slack approval updated account page to show waiting on approval fixed screenshot test refactor screenshot tests refactor screenshot test update slack controller & check for no api reques add new screenshot for non-requested account page added request account settings screenshot updated slack to not send email if user has api removed comment for account resource added requesting api access for academic users rebase with master add api access justification field to registration update screenshots added requesting api access for academic users minor bug fixes add role api for academic users update account settings page without role_api added requesting api access for academic users
bprize15
force-pushed
the
add-role-api
branch
from
38f4ba4 to
d55014d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/oncokb/oncokb-pipeline/issues/188
resolves https://github.com/oncokb/oncokb-pipeline/issues/189
resolves https://github.com/oncokb/oncokb-pipeline/issues/193
resolves https://github.com/oncokb/oncokb-pipeline/issues/162