[risc-v] cmake: added rvv intrinsics compilation check #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
make test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OneDNN build with https://github.com/riscv-collab/riscv-gnu-toolchain fails with the following error:
The GNU toolchain for RISC-V now supports RVV by default - ratified RVV1.0. All intrinsics have prefix __riscv64. Some compilers (clang, llvm) can compile a code contained intrinsics without this prefix (have overloaded functions). But GCC from riscv-gnu-toolchain doesn't have them - so cannot compile max pooling primitive from oneDNN.
The fix adds cmake configuration time check that corresponding intrinsics are really supported by the compiler.
This change is upstreamed from oneDNN fork repo maintained by OpenVINO organization.