Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xe, benchdnn, x64: Enable large buffer GEMM and Convolution testing for GPU #2276

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

xe, benchdnn, x64: Enable large buffer GEMM and Convolution testing for GPU #2276

wants to merge 17 commits into from

Conversation

rjoursler
Copy link
Contributor

@rjoursler rjoursler commented Dec 17, 2024 •
edited
Loading

Fixes issues encountered when testing large buffer GEMM and convolution operations on the GPU.

Also includes the patch from #2277 to enable tests to pass.

@rjoursler
xe: jit: codegen: add 64-bit immediate ecmp
0884a52
@rjoursler
xe: jit: ir: improve assert type issue message
277e10a
@rjoursler
xe: jit: ir: enable printing s64 type
c57860d
@rjoursler
xe: jit: conv: restrict usage to integer dimension sizes
3526f20
@rjoursler
xe: jit: v2: conv: disable large buffer support
cb121c0
@rjoursler
xe: ocl: enable large buffer offset support for ref_convolution
bfdcfbf
@rjoursler
xe: ocl: disable large buffer support for wino convolution
998e6a8
@rjoursler
xe: jit: gemm: disable large buffer jit:xe_hp implementation support
f14d67a
@rjoursler
xe: jit: force A64
9eafd8b
@rjoursler
xe: jit: gemm: use 64-bit arithmetic for ld offsets
618dee5
@rjoursler
xe: ocl: gemm: fix ref_gemm types
f77bc0f
@rjoursler
xe: jit: gemm: require 32-bit dimension size and strides
12aa72a
@rjoursler
x64: matmul: workaround large buffer reorder failure
fa77b1d
@rjoursler
benchdnn: conv: estimate count_ops for large sizes
5883659
@rjoursler
benchdnn: inputs: conv: add large buffer tests for gpu
365d83b
@rjoursler
benchdnn: avoid unnecessary GPU runtime checks
11b1282 
Workaround hang observed on some machines
@rjoursler
benchdnn: inputs: add large buffer matmul tests
e4ed9ec
@rjoursler rjoursler requested review from a team as code owners December 17, 2024 00:27
@github-actions github-actions bot added platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel component:tests Codeowner: @oneapi-src/onednn-arch labels Dec 17, 2024
@rjoursler
Copy link
Contributor Author

make test perf-gpu
set primitive=conv deconv matmul ip

dzarukin
dzarukin approved these changes Dec 17, 2024
View reviewed changes
tests/benchdnn/inputs/conv/test_conv_large_gpu
@@ -0,0 +1,11 @@
--dir=FWD_D,BWD_D,BWD_W
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--dir=FWD_D,BWD_D,BWD_W
--reset
--dir=FWD_D,BWD_D,BWD_W

@vpirogov vpirogov mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzarukin dzarukin dzarukin approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
component:tests Codeowner: @oneapi-src/onednn-arch platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjoursler @dzarukin