src: cpu: aarch64: Re-enable matmul and convolution static quantisation through ACL. #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renato-arantes
force-pushed
the
static_quant2
branch
from
e4b72e7 to
88cf5e0
Compare
renato-arantes
force-pushed
the
static_quant2
branch
from
88cf5e0 to
5cec04d
Compare
|
Hi @mgouicem, it's the same as before but more restrictive with Neoverse-N1 until the failing tests are fixed. |
theComputeKid
approved these changes
Dec 23, 2024
| if (!ok) return status::unimplemented; | ||
|
|
||
| if (weights_md_.ndims != 4) return status::unimplemented; | ||
|
|
||
| // reject in case the op is running in a Neoverse-N1 with mixed sign quantization. | ||
| if (!arm_compute::CPUInfo::get().has_i8mm() && src_t == dnnl_u8 |
There was a problem hiding this comment.
This if statement is the only difference b/w the previous version, right?
There was a problem hiding this comment.
Yes, that is true.
github-actions
bot
added
the
platform:cpu-aarch64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to re-enable
matmulandconvstatic quantization operations through ACL. Currently, the supported data type combinations ares8:s8:s8andu8:s8:u8. Neoverse-N1 is skipped until failing tests are fixed.General
make testandmake test_benchdnn_*) pass locally for each commit?