Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed-ranges namespace #1475

Closed
wants to merge 35 commits into from

Conversation

mateuszpn
Copy link

Use cmake -DCMAKE_CXX_STANDARD=20 to include DR to your project

SergeyKopienko and others added 18 commits March 13, 2024 12:29
…i-src#1410)

* Extend compiler support for USM buffer storage

* Workaround access::decorated

* Address review comment
…vice=FPGA_EMU (oneapi-src#1440)

Skipping tests with default device as FPGA or FPGA_EMU
…types (oneapi-src#1438)


Changes USM allocator allocated std::vectors from being processed like host-side iterators to being "passed directly" (into sycl kernels) when it is possible to detect them.  The C++ standard library implementation may or may not include allocator information in the iterator type.  If it does, we can detect such iterators, and treat them as "passed directly".  Where it is not possible, they are still treated as host-side iterators and wrapped in a sycl::buffer.
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
@BenBrock
Copy link
Contributor

BenBrock commented Apr 4, 2024

This PR currently applies clang-format to a bunch of oneDPL files that are not part of distributed ranges. We need to revert those changes, as formatting pre-existing code should not be part of this PR. We should limit this PR to only include changes to distributed ranges.

@BenBrock
Copy link
Contributor

BenBrock commented Apr 4, 2024

Please ignore my previous comment; I see now that this is a PR against the distributed-ranges branch, not against main, and it looks like the distributed-ranges branch is in good shape in terms of not applying these kinds of formatting changes. I assume you'll fix this in this PR before merging with distributed-ranges.

I went ahead and opened a draft PR for the whole distributed-ranges branch, just so I can easily look at what we're adding.

@mateuszpn mateuszpn closed this Apr 8, 2024
@mateuszpn mateuszpn deleted the dr_namespace branch May 14, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants