Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions workflow for publishing documentation #494

Merged
merged 4 commits into from
May 21, 2024

Conversation

rscohn2
Copy link
Member

@rscohn2 rscohn2 commented May 16, 2024

Description

Publish documentation to github pages with a github action

Addresses comments from earlier version: #482

@rscohn2 rscohn2 marked this pull request as ready for review May 16, 2024 20:28
@dnhsieh-intel
Copy link
Contributor

Thank you! I really appreciate the PR!

The built documentation looks different (probably the theme?):
Screenshot 2024-05-17 094326

Ping @fitchbe for the command to build documentation.

@fitchbe
Copy link
Contributor

fitchbe commented May 17, 2024

Hi, @dnhsieh-intel! I recommend referring to the oneMKL DPC++ reference repo as a model for set-up and build instructions. Regarding themes, the convention is to use the Sphinx "book" theme for Intel-proprietary product documentation on intel.com (IDZ) and the Sphinx "read-the-docs" theme for open-source projects.

@rscohn2
Copy link
Member Author

rscohn2 commented May 17, 2024

The conf.py is using sphinx_book_theme, but the doc looks like default alabaster to me. I might be missing a plugin in the install.

@rscohn2
Copy link
Member Author

rscohn2 commented May 19, 2024

The built documentation looks different (probably the theme?):

It turns out that the cmake build of the doc was broken. The original 0.1 commit had a conf.py and a conf.py.in. The cmake build used the conf.py.in. After 0.1, there were changes to the conf.py and it is clear that the published documentation was built using it, but not using cmake. I deleted conf.py and put the changes in conf.py.in + some additional changes so the cmake build would work and fixes for some warnings.

There are still some warnings about undefined references. It looks like the API part of the doc needs to be updated.

@rscohn2
Copy link
Member Author

rscohn2 commented May 21, 2024

@dnhsieh-intel : Using the current onemkl versions did not work: https://github.com/oneapi-src/oneMKL/actions/runs/9174663052/job/25225986051
I think it would require pinning all the versions, not just the top level.

I installed the latest versions and did a pip freeze to capture all the dependencies in the requirements.txt. Dependabot will keep them up to date.

@dnhsieh-intel
Copy link
Contributor

Big thanks! It worked when I tested on a local machine, probably because the environment is not "clean enough"...

@rscohn2
Copy link
Member Author

rscohn2 commented May 21, 2024

@Rbiessy, @mkrainiuk : I think this is ready to merge, but needs another approval

@rscohn2 rscohn2 merged commit 90bc218 into oneapi-src:develop May 21, 2024
6 checks passed
normallytangent pushed a commit to normallytangent/oneMKL that referenced this pull request Aug 6, 2024
Co-authored-by: Dai-Ni Hsieh <dai-ni.hsieh@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants