-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update oneapi to 2025 #610
Conversation
When you use a matrix to launch multiple jobs, the default behavior is to cancel all jobs if any fails. I pushed a change that will make it attempt to finish all jobs. |
It seems like the caching is not needed anymore. It used to take 5 minutes to install the compiler. Now it finishes in 68 seconds with no caching. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will you be able to force merge the PR given that the GitHub CI will fail with the lapack domain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are multiple ways to get the URL. This is what I found most convenient. Intel maintains the following files so they are updated at same time as other release channels. |
Co-authored-by: Dai-Ni Hsieh <dai-ni.hsieh@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I learned that we need to use -s
twice.
- name: Install Intel oneMKL | ||
if: steps.domain_check.outputs.result == 'true' | ||
run: | | ||
wget https://registrationcenter-download.intel.com/akdlm/IRC_NAS/79153e0f-74d7-45af-b8c2-258941adf58a/intel-onemkl-2025.0.0.940_offline.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed another wget
...
wget https://registrationcenter-download.intel.com/akdlm/IRC_NAS/79153e0f-74d7-45af-b8c2-258941adf58a/intel-onemkl-2025.0.0.940_offline.sh | |
wget --progress=dot:giga https://registrationcenter-download.intel.com/akdlm/IRC_NAS/79153e0f-74d7-45af-b8c2-258941adf58a/intel-onemkl-2025.0.0.940_offline.sh |
As mentioned in #606 , I pulled in the changes from this PR (plus the change requested by @dnhsieh-intel ) into that PR and all of the CI tests are green there. So if we want to keep a green CI, we can merge them together. Thanks!! |
Closing, incorporated into #606 |
Description
Update oneapi install to 2025. I removed setup-oneapi because I am not sure if I will be able to continue to maintain it. setup-oneapi used github caching to speed up install, but blas/lapack tests run for a long time and the acceleration doesn't matter so much. fft testing is much shorter so it will be slower.