Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude the CWD from the dependent DLL search #1330

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

dnmokhov
Copy link
Contributor

Description

Applies to all the generated oneTBB DLLs.

Reference:
https://learn.microsoft.com/en-us/cpp/build/reference/dependentloadflag
https://learn.microsoft.com/en-us/windows/win32/api/libloaderapi/nf-libloaderapi-loadlibraryexw

Value Meaning
LOAD_LIBRARY_SAFE_CURRENT_DIRS
0x00002000
If this value is used, loading a DLL for execution from the current directory is only allowed if it is under a directory in the Safe load list.
  • - git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

Signed-off-by: Dmitri Mokhov <dmitri.n.mokhov@intel.com>
Copy link
Contributor

@sarathnandu sarathnandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@omalyshe omalyshe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnmokhov dnmokhov merged commit 5b10a87 into master Mar 19, 2024
20 checks passed
@dnmokhov dnmokhov deleted the dev/dnmokhov/dependentloadflag branch March 19, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants