Fix assert in ravl_node_rank_difference_parent()#720
Merged
ldorau merged 1 commit intooneapi-src:mainfrom Sep 11, 2024
Merged
Conversation
Fix assert in ravl_node_rank_difference_parent(). ravl_node_rank() do not have to be positive - it can return (-1), so the assert has to be corrected. For example: if ravl_node_rank(p) = 0 and ravl_node_rank(n) = -1, then rv = 1. Ref: oneapi-src#717 Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
ldorau
force-pushed
the
Fix_assert_in_ravl_node_rank_difference_parent
branch
from
29917d6 to
dd41215
Compare
bratpiorka
approved these changes
Sep 11, 2024
lukaszstolarczuk
approved these changes
Sep 11, 2024
lplewa
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix assert in
ravl_node_rank_difference_parent().ravl_node_rank()do not have to be positive - it can return (-1), so the assert has to be corrected.For example:
if
ravl_node_rank(p) = 0andravl_node_rank(n) = -1, thenrv = 1.Ref: #717
Checklist
This patch is tested in #715