Skip to content

[HIP] Implement urMemImageGetInfo #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
veselypeta wants to merge 1 commit into from
Closed

[HIP] Implement urMemImageGetInfo #1017

veselypeta wants to merge 1 commit into from

Conversation

@veselypeta
Copy link
Contributor

@veselypeta veselypeta commented Oct 30, 2023 •
edited
Loading

This PR:

  • uses hipArray3DgetDescriptor to implement urMemImageGetInfo in the Hip adapter.

intel/llvm testing here

@veselypeta veselypeta requested a review from a team as a code owner October 30, 2023 15:19
@veselypeta veselypeta force-pushed the petr/hip-get-mem-info branch from 8eb5fe2 to 8e7f785 Compare October 30, 2023 15:20
@jinz2014
Copy link

jinz2014 commented Oct 31, 2023

Hip->HIP in 'Invalid Hip format specified' ?

@veselypeta veselypeta mentioned this pull request Oct 31, 2023
Closed
@aarongreig
Copy link
Contributor

aarongreig commented Oct 31, 2023

why doesn't this seem to need a change to the CTS match files? I'd expect it to make the MemImageGetInfo tests start passing

@veselypeta
Copy link
Contributor Author

veselypeta commented Oct 31, 2023

why doesn't this seem to need a change to the CTS match files? I'd expect it to make the MemImageGetInfo tests start passing

This will need to be done, but the memory tests are currently segfaulting until #1013 is merged. 👍

@kbenzie kbenzie added the conformance Conformance test suite issues. label Nov 2, 2023
@kbenzie kbenzie mentioned this pull request Nov 2, 2023
Closed
@veselypeta
Copy link
Contributor Author

veselypeta commented Nov 3, 2023

Covered in #1030

@veselypeta veselypeta closed this Nov 3, 2023
This was referenced Nov 14, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

conformance Conformance test suite issues.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@veselypeta @jinz2014 @aarongreig @kbenzie