Skip to content

[UR][CUDA] Fix compatibility with CUDA 11.x #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kbenzie merged 3 commits into from
Nov 24, 2023
Merged

[UR][CUDA] Fix compatibility with CUDA 11.x #1037

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fd39f3
[UR][CUDA] Fix compatibility with CUDA 11.x
al42and Nov 3, 2023
7ca370d
Fix formatting, use CUDA_VERSION instead of CUDART_VERSION
al42and Nov 3, 2023
807434f
Add support for flags with CUDA 11.4-11.8 (untested)
al42and Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion source/adapters/cuda/command_buffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,19 @@ urCommandBufferReleaseExp(ur_exp_command_buffer_handle_t hCommandBuffer) {
UR_APIEXPORT ur_result_t UR_APICALL
urCommandBufferFinalizeExp(ur_exp_command_buffer_handle_t hCommandBuffer) {
try {
const unsigned long long flags = 0;
#if CUDA_VERSION >= 12000
UR_CHECK_ERROR(cuGraphInstantiate(&hCommandBuffer->CudaGraphExec,
hCommandBuffer->CudaGraph, 0));
hCommandBuffer->CudaGraph, flags));
#elif CUDA_VERSION >= 11040
UR_CHECK_ERROR(cuGraphInstantiateWithFlags(
&hCommandBuffer->CudaGraphExec, hCommandBuffer->CudaGraph, flags));
#else
// Cannot use flags
UR_CHECK_ERROR(cuGraphInstantiate(&hCommandBuffer->CudaGraphExec,
hCommandBuffer->CudaGraph, nullptr,
nullptr, 0));
#endif
} catch (...) {
return UR_RESULT_ERROR_UNKNOWN;
}
Expand Down