[OpenCL] Address coverity issue with dodgy struct-to-array casts #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbenzie
suggested changes
Nov 10, 2023
Contributor
kbenzie
left a comment
kbenzie
left a comment
There was a problem hiding this comment.
urEnqueueMemImageRead also contains casts from ur_rect_office_t/ur_rect_region_t, we should fix those here also.
aarongreig
force-pushed
the
aaron/clAdapterCoverityArrayVSingleton
branch
from
7ea3e5d to
8be0482
Compare
kbenzie
approved these changes
Nov 10, 2023
Contributor
|
Seems |
Contributor
|
This also needs an https://github.com/intel/llvm PR. |
Also fix a similar issue coverity had with CreateProgramWithBinary which was passing array pointers straight through to the cl entry point by putting these params in local const arrays.
aarongreig
force-pushed
the
aaron/clAdapterCoverityArrayVSingleton
branch
from
8be0482 to
560a115
Compare
Contributor
|
Superceed by #1048 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix a similar issue coverity had with CreateProgramWithBinary which was passing array pointers straight through to the cl entry point by putting these params in local const arrays.
intel-llvm testing here intel/llvm#11860