Cherry-pick multi device compile spec changes#1083
Closed
aarongreig wants to merge 3 commits intooneapi-src:adaptersfrom
Closed
Cherry-pick multi device compile spec changes#1083aarongreig wants to merge 3 commits intooneapi-src:adaptersfrom
aarongreig wants to merge 3 commits intooneapi-src:adaptersfrom
Conversation
piProgramBuild receives a list of devices, while urProgramBuild does not. This produces a series of issues when a UR program needs to be created for a specific device. So define a new API, called urProgramBuildExp to pass this list. Authored-by: jaime.a.arteaga.molina@intel.com
Expand upon the introduction of `urProgramBuildExp` and include `urProgramCompileExp` and `urProgramLinkExp` which include a device-list in place of a context. These more closely align with the PI/OpenCL analogues but only to introduce device-lists, not all extant arguments from those entry-points. This patch also moves the `urProgramBuildExp` definition into an experimental feature file and introduces a brief document containing motivation.
Contributor
ur_adapter_level_zero.def : error LNK2001: unresolved external symbol urGetProgramExpProcAddrTable [D:\a\unified-runtime\unified-runtime\build\source\adapters\level_zero\ur_adapter_level_zero.vcxproj]We'll need to add |
kbenzie
approved these changes
Nov 15, 2023
jandres742
approved these changes
Nov 15, 2023
pbalcer
approved these changes
Nov 16, 2023
Contributor
|
I've pulled this change into #934 so we don't need a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow us to merge and upstream #934