[NATIVECPU] Implement correct reference counting for Native CPU adapter #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
reviewed
Nov 22, 2023
pbalcer
approved these changes
Nov 22, 2023
kbenzie
added a commit
that referenced
this pull request
Nov 28, 2023
[NATIVECPU] Implement correct reference counting for Native CPU adapter
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Nov 29, 2023
Combines the follow UR changes: * oneapi-src/unified-runtime#1037 * oneapi-src/unified-runtime#1097 * oneapi-src/unified-runtime#1106 * oneapi-src/unified-runtime#1039 * oneapi-src/unified-runtime#1088 Depends on #11893 merging first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some types in the Native CPU adapter didn't have correct reference counting semantics. This PR should fix it by providing correct implementations for the
retainandreleasefunctions.intel/llvm pull request: intel/llvm#11947