[CTS] Check if images are supported before testing#1144
Merged
kbenzie merged 2 commits intooneapi-src:mainfrom Apr 28, 2024
Merged
[CTS] Check if images are supported before testing#1144kbenzie merged 2 commits intooneapi-src:mainfrom
kbenzie merged 2 commits intooneapi-src:mainfrom
Conversation
kbenzie
force-pushed
the
benie/cts-check-image-support
branch
from
976032d to
6ab8c99
Compare
aarongreig
approved these changes
Dec 1, 2023
Contributor
|
I have updated the target branch of this PR from the |
kbenzie
force-pushed
the
benie/cts-check-image-support
branch
from
6ab8c99 to
124d361
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1144 +/- ##
==========================================
- Coverage 15.46% 15.42% -0.04%
==========================================
Files 238 238
Lines 33883 33977 +94
Branches 3747 3758 +11
==========================================
+ Hits 5239 5241 +2
- Misses 28593 28685 +92
Partials 51 51 ☔ View full report in Codecov by Sentry. |
kbenzie
force-pushed
the
benie/cts-check-image-support
branch
from
7212579 to
fe05045
Compare
Add checks on the value of the `UR_DEVICE_INFO_IMAGE_SUPPORTED` device query to the image test fixtures, skip the tests if images are not supported.
kbenzie
force-pushed
the
benie/cts-check-image-support
branch
4 times, most recently
from
b82d745 to
ce3417d
Compare
The return type of the `UR_DEVICE_INFO_IMAGE_SUPPORTED` query is `ur_bool_t` which is 1 byte. This patch removes the return type being cast to `uint32_t` which caused the query to fail when being pass a valid `propSize` of 1 byte.
kbenzie
force-pushed
the
benie/cts-check-image-support
branch
from
ce3417d to
b1da44d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add checks on the value of the
UR_DEVICE_INFO_IMAGE_SUPPORTEDdevice query to the image test fixtures, skip the tests if images are not supported.