[cuda][null][common] fix a few coverity issues#1203
Merged
wlemkows merged 1 commit intooneapi-src:mainfrom Dec 20, 2023
Merged
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1203 +/- ##
=======================================
Coverage ? 15.73%
=======================================
Files ? 223
Lines ? 31465
Branches ? 3555
=======================================
Hits ? 4951
Misses ? 26463
Partials ? 51 ☔ View full report in Codecov by Sentry. |
Contributor
Author
Contributor
|
I'll look into the hip issue, it looks a lot like a few other issues that came up around |
aarongreig
reviewed
Dec 19, 2023
aarongreig
approved these changes
Dec 19, 2023
wlemkows
approved these changes
Dec 19, 2023
mmoadeli
approved these changes
Dec 20, 2023
8 tasks
kbenzie
pushed a commit
to kbenzie/unified-runtime
that referenced
this pull request
Jan 16, 2024
[cuda][null][common] fix a few coverity issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix all non-test related coverity issues except for:
https://scan7.scan.coverity.com/reports.htm#v21214/p15954/fileInstanceId=155217701&defectInstanceId=19136875&mergedDefectId=1574236, which is a race in the HIP adapter - that looks like it might be a false positive, but I'm not sure.