[UR][HIP] Fix include for AMD COMGR#1222
Merged
kbenzie merged 3 commits intooneapi-src:mainfrom Jan 4, 2024
Merged
Conversation
sommerlukas
force-pushed
the
lukas/comgr-include-rocm4
branch
from
2b1d73a to
327220d
Compare
Contributor
Author
|
Pull request in intel/llvm: intel/llvm#12286 |
JackAKirk
approved these changes
Jan 3, 2024
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
sommerlukas
force-pushed
the
lukas/comgr-include-rocm4
branch
from
9d3ddd6 to
d398d4a
Compare
Contributor
Author
|
The |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1222 +/- ##
=======================================
Coverage 15.73% 15.73%
=======================================
Files 223 223
Lines 31477 31477
Branches 3558 3558
=======================================
Hits 4953 4953
Misses 26473 26473
Partials 51 51 ☔ View full report in Codecov by Sentry. |
8 tasks
kbenzie
approved these changes
Jan 4, 2024
kbenzie
added
ready to merge
kbenzie
added a commit
to kbenzie/unified-runtime
that referenced
this pull request
Jan 4, 2024
…de-rocm4 [UR][HIP] Fix include for AMD COMGR
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code object finalization for kernel fusion uses the AMD COMGR. The location of the corresponding header changed between ROCm version 4 and 5.
This PR fixes the include for ROCm version 4.