Skip to content

[L0] Allocate event pools efficiently in multi-device scenarios#1324

Merged
aarongreig merged 1 commit intooneapi-src:mainfrom
raiyanla:event-opt
Feb 12, 2024
Merged

[L0] Allocate event pools efficiently in multi-device scenarios#1324
aarongreig merged 1 commit intooneapi-src:mainfrom
raiyanla:event-opt

Conversation

@raiyanla
Copy link
Contributor

@raiyanla raiyanla commented Feb 8, 2024

No description provided.

@raiyanla raiyanla force-pushed the event-opt branch 3 times, most recently from 54d1571 to b0e5585 Compare February 8, 2024 16:29
@raiyanla
Copy link
Contributor Author

raiyanla commented Feb 8, 2024

CI tests for L0 Adapter should all be fixed now.

@pbalcer pbalcer added the v0.8.x Include in the v0.8.x release label Feb 8, 2024
@aarongreig
Copy link
Contributor

as we will be looking to merge this quickly make sure you create a (draft) PR in https://github.com/intel/llvm to pull in these changes and get them tested on the CI there ASAP @raiyanla

@raiyanla
Copy link
Contributor Author

raiyanla commented Feb 8, 2024

as we will be looking to merge this quickly make sure you create a (draft) PR in https://github.com/intel/llvm to pull in these changes and get them tested on the CI there ASAP @raiyanla

Sure @aarongreig , yes will create that now, to confirm if everything is okay on that CI.

Edit: Placed it in intel/llvm#12666

@nrspruit nrspruit added the level-zero L0 adapter specific issues label Feb 8, 2024
@raiyanla
Copy link
Contributor Author

raiyanla commented Feb 8, 2024

Seeing some SYCL E2E CI tests failing in the LLVM draft PR (intel/llvm#12666), will be attempting to resolve those ASAP.

Update: Resolved almost all SYCL E2E tests now, just one interop test failing left, looking to root the cause atm.

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47102cb) 15.33% compared to head (92a0250) 15.33%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1324      +/-   ##
==========================================
- Coverage   15.33%   15.33%   -0.01%     
==========================================
  Files         241      241              
  Lines       34820    34821       +1     
  Branches     3989     3989              
==========================================
  Hits         5340     5340              
- Misses      29429    29430       +1     
  Partials       51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nrspruit nrspruit marked this pull request as ready for review February 9, 2024 20:48
@nrspruit nrspruit requested review from a team as code owners February 9, 2024 20:48
Signed-off-by: Raiyan Latif <raiyan.latif@intel.com>
Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far after the last change, I have updated the intel/llvm patch to see if there any other issues we have missed.

@nrspruit nrspruit added the ready to merge Added to PR's which are ready to merge label Feb 10, 2024
@nrspruit
Copy link
Contributor

Hello @oneapi-src/unified-runtime-maintain , please merge this change when available.

Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

command_buffer.cpp changes LGTM

@aarongreig aarongreig merged commit be849b2 into oneapi-src:main Feb 12, 2024
aarongreig added a commit to aarongreig/unified-runtime that referenced this pull request Feb 12, 2024
[L0] Allocate event pools efficiently in multi-device scenarios
aarongreig added a commit to aarongreig/unified-runtime that referenced this pull request Feb 12, 2024
[L0] Allocate event pools efficiently in multi-device scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level-zero L0 adapter specific issues ready to merge Added to PR's which are ready to merge v0.8.x Include in the v0.8.x release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants