Skip to content

Conversation

@GeorgeWeb
Copy link
Contributor

@GeorgeWeb GeorgeWeb commented Feb 29, 2024

This PR is just to make sure there errors are reported accordingly if new fails to allocate the requested space when creating UR event object from a native event.

inte/llvm CI: intel/llvm#12895

@GeorgeWeb GeorgeWeb changed the title [CUDACatch and report bad_alloc errors for event object creation [CUDA][HIP] Catch and report bad_alloc errors for event object creation Feb 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.51%. Comparing base (78ef1ca) to head (4c3f9ab).
Report is 96 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1397      +/-   ##
==========================================
- Coverage   14.82%   12.51%   -2.32%     
==========================================
  Files         250      239      -11     
  Lines       36220    35949     -271     
  Branches     4094     4076      -18     
==========================================
- Hits         5369     4498     -871     
- Misses      30800    31447     +647     
+ Partials       51        4      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GeorgeWeb GeorgeWeb force-pushed the georgi/check-allocation-error-on-event-from-native-handle branch from c19383b to a4a9b16 Compare February 29, 2024 15:05
@GeorgeWeb GeorgeWeb marked this pull request as ready for review March 4, 2024 15:47
@GeorgeWeb GeorgeWeb requested review from a team as code owners March 4, 2024 15:47
@GeorgeWeb GeorgeWeb requested a review from keyradical March 4, 2024 15:47
Copy link
Contributor

@keyradical keyradical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kbenzie kbenzie added cuda CUDA adapter specific issues hip HIP adapter specific issues labels Apr 10, 2024
@GeorgeWeb GeorgeWeb added the ready to merge Added to PR's which are ready to merge label May 20, 2024
@kbenzie kbenzie merged commit 5083f4f into oneapi-src:main May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda CUDA adapter specific issues hip HIP adapter specific issues ready to merge Added to PR's which are ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants