[L0] Enable Batching out of order commands without signal events#1526
Merged
kbenzie merged 15 commits intooneapi-src:mainfrom May 2, 2024
Merged
[L0] Enable Batching out of order commands without signal events#1526kbenzie merged 15 commits intooneapi-src:mainfrom
kbenzie merged 15 commits intooneapi-src:mainfrom
Conversation
Contributor
nrspruit
commented
Apr 17, 2024
nrspruit
commented
- Given a command being enqueued without dependencies or dependencies outside of a given batch of commands, then signal the event at the end of the command list allowing for parallel execution of the commands.
nrspruit
force-pushed
the
event_signal_optional
branch
from
2375f0f to
96a860e
Compare
github-actions
bot
added
images
Contributor
MichalMrozek
left a comment
MichalMrozek
left a comment
There was a problem hiding this comment.
this mode needs to be device specific as for new HW generations we do not want to do this
nrspruit
force-pushed
the
event_signal_optional
branch
from
0dba278 to
38a8478
Compare
nrspruit
force-pushed
the
event_signal_optional
branch
from
64bf5e3 to
a2611ce
Compare
nrspruit
force-pushed
the
event_signal_optional
branch
from
44a012f to
6f7f1c1
Compare
nrspruit
force-pushed
the
event_signal_optional
branch
from
6f7f1c1 to
234e8d9
Compare
nrspruit
force-pushed
the
event_signal_optional
branch
from
234e8d9 to
dfaceb5
Compare
nrspruit
force-pushed
the
event_signal_optional
branch
from
dfaceb5 to
6c9e7ec
Compare
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
force-pushed
the
event_signal_optional
branch
from
3c44248 to
6812c82
Compare
…xists Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
force-pushed
the
event_signal_optional
branch
from
686e0b1 to
d621b50
Compare
winstonzhang-intel
approved these changes
Apr 25, 2024
raiyanla
approved these changes
Apr 25, 2024
pbalcer
approved these changes
Apr 26, 2024
Contributor
pbalcer
left a comment
pbalcer
left a comment
There was a problem hiding this comment.
LGTM, just a few minor stylistic comments. I wasn't able to fully follow all the logic, but overall the changes make sense.
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
pbalcer
approved these changes
Apr 26, 2024
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Apr 26, 2024
- pre-commit PR for oneapi-src/unified-runtime#1526 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Seanst98
approved these changes
May 2, 2024
EwanC
reviewed
May 2, 2024
Comment on lines
+962
to
+963
| false, NumEventsInWaitList, | ||
| EventWaitList, false)); |
Contributor
There was a problem hiding this comment.
There isn't a UR wait list for this command-list, it's ordering is enforced by calling Queue->executeCommandList(SignalCommandList, false, false); after the call on line 953
ZE2UR_CALL(zeCommandQueueExecuteCommandLists,
(ZeCommandQueue, 1, &CommandBuffer->ZeCommandList, ZeFence));
(see https://github.com/intel/llvm/blob/sycl/sycl/doc/design/CommandGraph.md#level-zero)
isaacault
approved these changes
May 2, 2024
5 tasks
sarnex
pushed a commit
to intel/llvm
that referenced
this pull request
May 2, 2024
…13462) - pre-commit PR for oneapi-src/unified-runtime#1526 --------- Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com> Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
kbenzie
added a commit
to kbenzie/unified-runtime
that referenced
this pull request
May 3, 2024
[L0] Enable Batching out of order commands without signal events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.