Skip to content

Conversation

@pbalcer
Copy link
Contributor

@pbalcer pbalcer commented Jun 3, 2024

CodeQL started failing on Windows. Hoping a simple update fixes the problem.

CodeQL started failing on Windows. Hoping a simple update fixes the problem.
@pbalcer pbalcer requested a review from a team as a code owner June 3, 2024 12:37
@github-actions github-actions bot added the ci/cd Continuous integration/devliery label Jun 3, 2024
@pbalcer
Copy link
Contributor Author

pbalcer commented Jun 3, 2024

Well, it didn't help :( We might need to disable this job for now. I triggered a rerun of a previously successful job on main:
https://github.com/oneapi-src/unified-runtime/actions/runs/9321220672/job/25735621065

@kbenzie
Copy link
Contributor

kbenzie commented Jun 3, 2024

Well, it didn't help :( We might need to disable this job for now. I triggered a rerun of a previously successful job on main: https://github.com/oneapi-src/unified-runtime/actions/runs/9321220672/job/25735621065

Looks like this passed, does that mean there's actually a CodeQL issue and the reporting mechanism is somehow broken?

@pbalcer
Copy link
Contributor Author

pbalcer commented Jun 3, 2024

Looks like this passed, does that mean there's actually a CodeQL issue and the reporting mechanism is somehow broken?

Hard to say. The only relevant difference between main and say, #1701, is different origin branch. Can you merge #1701 to see if the CodeQL build on main passes?

@kbenzie
Copy link
Contributor

kbenzie commented Jun 4, 2024

#1692 has passed out of the blue also. Very odd.

@pbalcer
Copy link
Contributor Author

pbalcer commented Jun 4, 2024

CodeQL on main, after I merged #171, also passed: https://github.com/oneapi-src/unified-runtime/actions/runs/9364748464/job/25778404126

No clue what's going on.

@pbalcer pbalcer closed this Jun 4, 2024
@pbalcer pbalcer deleted the pbalcer-codeql-update branch June 4, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd Continuous integration/devliery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants