Skip to content

[HIP] Fix error code for urContextCreateWithNativeHandle #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kbenzie merged 1 commit into from
Jun 20, 2024
Merged

[HIP] Fix error code for urContextCreateWithNativeHandle #1762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions source/adapters/cuda/context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,16 +142,11 @@ UR_APIEXPORT ur_result_t UR_APICALL urContextGetNativeHandle(
}

UR_APIEXPORT ur_result_t UR_APICALL urContextCreateWithNativeHandle(
ur_native_handle_t hNativeContext, uint32_t numDevices,
const ur_device_handle_t *phDevices,
const ur_context_native_properties_t *pProperties,
ur_context_handle_t *phContext) {
std::ignore = hNativeContext;
std::ignore = numDevices;
std::ignore = phDevices;
std::ignore = pProperties;
std::ignore = phContext;

[[maybe_unused]] ur_native_handle_t hNativeContext,
[[maybe_unused]] uint32_t numDevices,
[[maybe_unused]] const ur_device_handle_t *phDevices,
[[maybe_unused]] const ur_context_native_properties_t *pProperties,
[[maybe_unused]] ur_context_handle_t *phContext) {
return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
}

Expand Down
9 changes: 6 additions & 3 deletions source/adapters/hip/context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,12 @@ UR_APIEXPORT ur_result_t UR_APICALL urContextGetNativeHandle(
}

UR_APIEXPORT ur_result_t UR_APICALL urContextCreateWithNativeHandle(
ur_native_handle_t, uint32_t, const ur_device_handle_t *,
const ur_context_native_properties_t *, ur_context_handle_t *) {
return UR_RESULT_ERROR_INVALID_OPERATION;
[[maybe_unused]] ur_native_handle_t hNativeContext,
[[maybe_unused]] uint32_t numDevices,
[[maybe_unused]] const ur_device_handle_t *phDevices,
[[maybe_unused]] const ur_context_native_properties_t *pProperties,
[[maybe_unused]] ur_context_handle_t *phContext) {
return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
}

UR_APIEXPORT ur_result_t UR_APICALL urContextSetExtendedDeleter(
Expand Down
3 changes: 0 additions & 3 deletions test/conformance/context/context_adapter_hip.match
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +0,0 @@
urContextCreateWithNativeHandleTest.Success/AMD_HIP_BACKEND___{{.*}}_
urContextCreateWithNativeHandleTest.SuccessWithOwnedNativeHandle/AMD_HIP_BACKEND___{{.*}}_
urContextCreateWithNativeHandleTest.SuccessWithUnOwnedNativeHandle/AMD_HIP_BACKEND___{{.*}}_