[L0 v2] event improvements #1893
Conversation
pbalcer
force-pushed
the
event_no_return
branch
from
319388a to
f8b7a94
Compare
igchor
changed the title
|
|
||
| ZE2UR_CALL_THROWS(zeEventPoolCreate, | ||
| (context->ZeContext, &desc, 1, | ||
| (context->hContext, &desc, 1, |
There was a problem hiding this comment.
I think we should have getters for ze handles. But we can do that later.
There was a problem hiding this comment.
Yes, agree. I actually have the getters implemented already on a branch with enqueue implementation because we need them to be able to reuse some code from legacy adapter (like program.cpp)
igchor
force-pushed
the
event_no_return
branch
2 times, most recently
from
59b6314 to
e532d78
Compare
igchor
force-pushed
the
event_no_return
branch
3 times, most recently
from
c884715 to
364dcce
Compare
igchor
force-pushed
the
event_no_return
branch
3 times, most recently
from
21a30e6 to
4b30c1a
Compare
EwanC
left a comment
EwanC
left a comment
There was a problem hiding this comment.
It looks like there are two changes in this PR, an update to GitHub workflows to run the V2 tests, and a change to the v2 event implementation. Should these be separate PRs?
By mistake, my previous PR disabled the building L0 v2 adapter on CI, and this PR enables the build back. The improvements also contain a compilation fix, which is required for the build to pass. I could split it, but then the changes wouldn't be tested on the PR. |
EwanC
left a comment
EwanC
left a comment
There was a problem hiding this comment.
command-buffer match file changes LGTM
on every event release.
by changing order of members. Provider should be destroyed last, after all ur_events are destroyed (ur_event dtor can put ze_event_handle_t back to the provider's cache).
3 participants
No description provided.