Skip to content

Map ur_bool_t to cl_bool in sampler getinfo for opencl adapter #1896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omarahmed1111 merged 1 commit into from
Aug 2, 2024
Merged

Map ur_bool_t to cl_bool in sampler getinfo for opencl adapter #1896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 32 additions & 10 deletions source/adapters/opencl/sampler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,16 +158,38 @@ urSamplerGetInfo(ur_sampler_handle_t hSampler, ur_sampler_info_t propName,
static_assert(sizeof(cl_addressing_mode) ==
sizeof(ur_sampler_addressing_mode_t));

size_t CheckPropSize = 0;
ur_result_t Err = mapCLErrorToUR(
clGetSamplerInfo(cl_adapter::cast<cl_sampler>(hSampler), SamplerInfo,
propSize, pPropValue, &CheckPropSize));
if (pPropValue && CheckPropSize != propSize) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
UR_RETURN_ON_FAILURE(Err);
if (pPropSizeRet) {
*pPropSizeRet = CheckPropSize;
ur_result_t Err = UR_RESULT_SUCCESS;
// ur_bool_t have a size of uint8_t, but cl_bool size have the size of
// uint32_t so this adjust UR_SAMPLER_INFO_NORMALIZED_COORDS info to map
// between them.
if (propName == UR_SAMPLER_INFO_NORMALIZED_COORDS) {
cl_bool normalized_coords = false;
Err = mapCLErrorToUR(
clGetSamplerInfo(cl_adapter::cast<cl_sampler>(hSampler), SamplerInfo,
sizeof(cl_bool), &normalized_coords, nullptr));
if (pPropValue && propSize != sizeof(ur_bool_t)) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
UR_RETURN_ON_FAILURE(Err);
if (pPropValue) {
*static_cast<ur_bool_t *>(pPropValue) =
static_cast<ur_bool_t>(normalized_coords);
}
if (pPropSizeRet) {
*pPropSizeRet = sizeof(ur_bool_t);
}
} else {
size_t CheckPropSize = 0;
Err = mapCLErrorToUR(
clGetSamplerInfo(cl_adapter::cast<cl_sampler>(hSampler), SamplerInfo,
propSize, pPropValue, &CheckPropSize));
if (pPropValue && CheckPropSize != propSize) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
UR_RETURN_ON_FAILURE(Err);
if (pPropSizeRet) {
*pPropSizeRet = CheckPropSize;
}
}

// Convert OpenCL returns to UR
Expand Down