[L0] Make destructor of the context virtual #1956
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make sure that v2::context will release all the resources on context destruction.
nrspruit
approved these changes
Aug 9, 2024
Contributor
|
@igchor Could you please create an Intel/llvm PR for this? Thanks! |
Contributor
Author
This PR only targets v0.10.0rc as the problem is already fixed on main (by making L0 v2 a separate adapter) and intel/llvm won't compile with the 0.10.0 |
Contributor
|
I've cherry-picked this onto v0.10.0rc |
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to make sure that v2::context will release all the resources on context destruction.
This patch is not applicable to main branch as we already removed the inheritance there.