[L0] make device id an optional #1957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since device id is initialized later (not in ctor), make it optional to avoid using uninitialized value.
nrspruit
approved these changes
Aug 9, 2024
nrspruit
added
v0.10.x
Contributor
|
Could you please create a testing PR on intel/llvm for this to merge it? Thanks! |
Contributor
Author
Sure, done. intel/llvm#15077 |
kbenzie
pushed a commit
that referenced
this pull request
Aug 20, 2024
[L0] make device id an optional
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since device id is initialized later (not in ctor), make it optional to avoid using uninitialized value.