Skip to content

[NATIVECPU] Add lock_guard when stopping threads #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omarahmed1111 merged 1 commit into from
Aug 20, 2024
Merged

[NATIVECPU] Add lock_guard when stopping threads #1965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions source/adapters/native_cpu/threadpool.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,11 @@ class worker_thread {

// Waits for all tasks to finish and destroys the worker thread
inline void stop() {
m_isRunning.store(false, std::memory_order_release);
m_startWorkCondition.notify_all();
{
std::lock_guard<std::mutex> lock(m_workMutex);
m_isRunning.store(false, std::memory_order_release);
m_startWorkCondition.notify_all();
}
if (m_worker.joinable()) {
// Wait for the worker thread to finish handling the task queue
m_worker.join();
Expand Down