Fix CL adapter assuming incorrect type for sub group query. #1972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
LLVM PR intel/llvm#15074 |
aarongreig
force-pushed
the
aaron/fixSubGroupMaxSizeAssert
branch
2 times, most recently
from
ecc855e to
f61577c
Compare
martygrant
approved these changes
Aug 15, 2024
Contributor
|
@aarongreig is the intel/llvm failures related, I don't think it does, but just confirming with you? |
Contributor
Author
|
No, they're level zero fails and this only touches the CL adapter. I'll push just now and hopefully they go away. |
aarongreig
force-pushed
the
aaron/fixSubGroupMaxSizeAssert
branch
from
f61577c to
3c34eeb
Compare
On a fallback path used when the clGetKernelSubGroupInfo query isn't supported the adapter tries the UR_DEVICE_INFO_SUB_GROUP_SIZES_INTEL device info query via urDeviceGetInfo. It currently assumes the type returned by that query is size_t, this patch corrects that to uint32_t.
omarahmed1111
force-pushed
the
aaron/fixSubGroupMaxSizeAssert
branch
from
3c34eeb to
0a1ed83
Compare
kbenzie
pushed a commit
that referenced
this pull request
Aug 20, 2024
Fix CL adapter assuming incorrect type for sub group query.
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a fallback path used when the clGetKernelSubGroupInfo query isn't supported the adapter tries the UR_DEVICE_INFO_SUB_GROUP_SIZES_INTEL device info query via urDeviceGetInfo. It currently assumes the type returned by that query is size_t, this patch corrects that to uint32_t.