[L0] Fix urEnqueueDeviceGlobalVariableWrite to use device specific mo… #2096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dules - Fixed urEnqueueDeviceGlobalVariableWrite to check the map for a device specific module for the device used by the queue if it exists, otherwise use the ZeModule in the Program handle. Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Sep 16, 2024
…c module -pre-commit PR for oneapi-src/unified-runtime#2096 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
pbalcer
approved these changes
Sep 16, 2024
raiyanla
approved these changes
Sep 16, 2024
kbenzie
pushed a commit
that referenced
this pull request
Sep 17, 2024
…bleWrite [L0] Fix urEnqueueDeviceGlobalVariableWrite to use device specific mo…
4 tasks
zhaomaosu
reviewed
Sep 18, 2024
| ) { | ||
| std::scoped_lock<ur_shared_mutex> lock(Queue->Mutex); | ||
|
|
||
| ze_module_handle_t ZeModule{}; |
There was a problem hiding this comment.
Do we need to apply this fix to urEnqueueDeviceGlobalVariableRead() as well?
There was a problem hiding this comment.
Yes, we DO need to read op to be fixed as well. Tagging @nrspruit .
winstonzhang-intel
added a commit
to winstonzhang-intel/unified-runtime
that referenced
this pull request
Sep 19, 2024
modules Follow up to oneapi-src#2096 to update urEnqueueDeviceGlobalVariableRead as well. Signed-off-by: Winston Zhang <winston.zhang@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dules