[L0] Fix Counter Based Event Default signal given placeholder #2097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Sep 16, 2024
nrspruit
commented
- When a counter based event is created and is expected to be already signalled, then those events either need to be labelled as Completed==true or they need to be signalled on the device vs the host.
- Now, all places where host signal was skipped, those events are marked "Completed" such that those events will be skipped in the waitlist and in the case of the multi device, the event will be signalled on the device as part of the execute with the previous waitlist.
- When a counter based event is created and is expected to be already signalled, then those events either need to be labelled as Completed==true or they need to be signalled on the device vs the host. - Now, all places where host signal was skipped, those events are marked "Completed" such that those events will be skipped in the waitlist and in the case of the multi device, the event will be signalled on the device as part of the execute with the previous waitlist. Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
force-pushed
the
fix_cb_event_signalling
branch
from
1699ae6 to
bd5ed37
Compare
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Sep 16, 2024
-pre-commit PR oneapi-src/unified-runtime#2097 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
raiyanla
approved these changes
Sep 16, 2024
pbalcer
approved these changes
Sep 17, 2024
kbenzie
pushed a commit
that referenced
this pull request
Sep 17, 2024
[L0] Fix Counter Based Event Default signal given placeholder
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.