Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to align CTS and Spec for Memory #2233

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Oct 25, 2024

  1. Improvements to align CTS and Spec for Memory:

    - Add tests for UR_RESULT_ERROR_INVALID_NULL/HOST_POINTER for urMemImageCreate and urMemBufferCreate
    - Add missing error condition to spec for urMemImageCreate for checking type of image description struct
    - Add tests for UR_RESULT_ERROR_INVALID_NULL_HANDLE/POINTER for urMemBuffer/ImageCreateWithnativeHandle
    - Remove skip for urMemImageCreateWithNativeHandle - buffer was invalid as it was never instantiated in fixture struct
    - Update image format used in urMemImageTest fixture as it was invalid and likely to cause previously skipped test to fail (which now pass)
    - Add missing DDI table entry for urMemImageCreateWithNativeHandle for OpenCL
    - Add test for using different ur_mem_flag_t flags with urMemBufferPartition
    - Add missing UR_MEM_INFO_REFERENCE_COUNT to spec for urMemGetInfo and added test for this in urMemRetain/Release
    - Removed assert in L0 urMemGetInfo which would fail if mem type is not image or the query is not a context query
    - Fixed potential bug with HIP urMemGetNativeHandle which would fail if the mem handle was an image because use of std::variant
    martygrant committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    cf78d84 View commit details
    Browse the repository at this point in the history