[DeviceAsan] Enlarge nullpointer redzone to better detect problem #2243
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
yingcong-wu
changed the title
AllanZyne
reviewed
Oct 25, 2024
| @@ -16,6 +16,8 @@ | |||
| #include "common.hpp" | |||
| #include <unordered_set> | |||
|
|
|||
| #define NULLPTR_REDZONE_SIZE (4096) | |||
There was a problem hiding this comment.
add a comment about why choose this size
There was a problem hiding this comment.
this macro needn't be in header file, and I suggest using constexpr to define this constant
There was a problem hiding this comment.
I choose this size becuase it is a common page value, and I don't have any other good reasons for it.
There was a problem hiding this comment.
You can query the size of page by GetVirtualMemGranularity.
There was a problem hiding this comment.
I don't think that is necessary. Even when we have the page size, how many pages should we use? I think some simple value is good enough for now.
Also, this value don't have to align with any page size, that is not such requirement for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, print out the triggering address in the error report.