Skip to content

[L0] Updated Driver In order lists check and required version #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nrspruit wants to merge 1 commit into from
Closed

[L0] Updated Driver In order lists check and required version #2491

nrspruit wants to merge 1 commit into from

Conversation

@nrspruit
Copy link
Contributor

@nrspruit nrspruit commented Dec 19, 2024 •
edited
Loading

  • Cleaned up the checks for driver in order lists and migrated the check
    to platform.
  • Updated version needed to match version with fixes.
  • Fixed sync Immediate command List in order flag type.

@nrspruit nrspruit requested review from a team as code owners December 19, 2024 17:18
@nrspruit nrspruit requested a review from hdelan December 19, 2024 17:18
@github-actions github-actions bot added level-zero L0 adapter specific issues command-buffer Command Buffer feature addition/changes/specification labels Dec 19, 2024
@nrspruit nrspruit force-pushed the enable_driver_in_order_compat_check branch from 6e4f1a9 to f072da3 Compare December 19, 2024 17:22
@nrspruit
Copy link
Contributor Author

nrspruit commented Dec 19, 2024

Not targeted to v0.11.x, this will be for v0.12.x

@nrspruit nrspruit mentioned this pull request Dec 19, 2024
Closed
hdelan
hdelan reviewed Jan 6, 2025
View reviewed changes
@nrspruit nrspruit force-pushed the enable_driver_in_order_compat_check branch from f072da3 to f0c556b Compare January 14, 2025 16:08
@nrspruit nrspruit force-pushed the enable_driver_in_order_compat_check branch from f0c556b to d13db51 Compare January 14, 2025 16:51
@nrspruit nrspruit force-pushed the enable_driver_in_order_compat_check branch from d13db51 to 23a9979 Compare January 15, 2025 16:57
@nrspruit
Copy link
Contributor Author

nrspruit commented Jan 15, 2025

There are some errors suddenly in the SYCL tests with this enabled. I am going to set this to "draft" until I can determine why they started to fail.

@nrspruit nrspruit marked this pull request as draft January 15, 2025 23:02
@nrspruit nrspruit force-pushed the enable_driver_in_order_compat_check branch from 23a9979 to 16e070f Compare January 24, 2025 00:08
@nrspruit nrspruit force-pushed the enable_driver_in_order_compat_check branch 3 times, most recently from 108d976 to a0da40d Compare January 28, 2025 17:46
@nrspruit nrspruit marked this pull request as ready for review January 28, 2025 17:48
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Compute Benchmarks level_zero run (with params: ):
https://github.com/oneapi-src/unified-runtime/actions/runs/13016551883

@pbalcer
Copy link
Contributor

pbalcer commented Jan 30, 2025

Perf looks good, but I had to use compute runtime from yesterday.

@nrspruit
Copy link
Contributor Author

nrspruit commented Jan 30, 2025

Perf looks good, but I had to use compute runtime from yesterday.

Thanks, I am trying to determine why Graph/RecordReplay/barrier_multi_queue.cpp is failing in CI only, I cannot reproduce the failure outside of the CI even with the same version of the driver and compiler libraries.

ie here:
https://github.com/intel/llvm/actions/runs/13020477272/job/36320344367?pr=16431

I think this may be failing due to a memory leak that I fixed in this PR, but why it is failing now is not clear.

Once I can ensure that is not an issue or resolve it, then this patch should be ready to go.

@nrspruit nrspruit force-pushed the enable_driver_in_order_compat_check branch from c759860 to 03574ae Compare January 30, 2025 16:50
@nrspruit nrspruit force-pushed the enable_driver_in_order_compat_check branch from 03574ae to e322cd7 Compare February 7, 2025 18:24
@nrspruit nrspruit force-pushed the enable_driver_in_order_compat_check branch from e322cd7 to 4ebc29a Compare February 7, 2025 21:32
@github-actions github-actions bot added loader Loader related feature/bug conformance Conformance test suite issues. specification Changes or additions to the specification experimental Experimental feature additions/changes/specification cuda CUDA adapter specific issues hip HIP adapter specific issues opencl OpenCL adapter specific issues native-cpu Native CPU adapter specific issues labels Feb 7, 2025
@nrspruit nrspruit force-pushed the enable_driver_in_order_compat_check branch 2 times, most recently from 1fd368a to 65d35b2 Compare February 10, 2025 16:47
@nrspruit nrspruit force-pushed the enable_driver_in_order_compat_check branch 2 times, most recently from 136d82e to b848900 Compare February 10, 2025 17:02
@github-actions github-actions bot added the ci/cd Continuous integration/devliery label Feb 10, 2025
@nrspruit nrspruit force-pushed the enable_driver_in_order_compat_check branch from b848900 to dc69961 Compare February 11, 2025 15:23
@nrspruit nrspruit force-pushed the enable_driver_in_order_compat_check branch from dc69961 to 16ee5c8 Compare February 11, 2025 17:39
@martygrant
Copy link
Contributor

martygrant commented Feb 20, 2025

Unified Runtime -> intel/llvm Repo Move Notice

Information

The source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory,
all future development will now be carried out there. This was done in intel/llvm#17043.

The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime.

The contribution guide has been updated with new instructions for contributing to Unified Runtime.

PR Migration

All open PRs including this one will be labelled auto-close and shall be automatically closed after 30 days.
To allow for some breathing space, this automation will not be enabled until next week (27/02/2025).

Should you wish to continue with your PR you will need to migrate it to intel/llvm.
We have provided a script to help automate this process.

This is an automated comment.

nrspruit added a commit to nrspruit/llvm that referenced this pull request Feb 20, 2025
@nrspruit
[UR][L0] Updated Driver In order lists check and required version
6faa6ef 
-pre-commit PR for oneapi-src/unified-runtime#2491

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
@yingcong-wu @nrspruit
[L0] Updated Driver In order lists check and required version
5e70d36 
- Cleaned up the checks for driver in order lists and migrated the check
  to platform.
- Updated version needed to match version with fixes.
- Fixed sync Immediate command List in order flag type.

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
@nrspruit nrspruit force-pushed the enable_driver_in_order_compat_check branch from 16ee5c8 to 5e70d36 Compare February 20, 2025 20:43
@nrspruit
Copy link
Contributor Author

nrspruit commented Feb 20, 2025

changes moved to intel/llvm#17106

@nrspruit nrspruit closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbalcer pbalcer pbalcer approved these changes

+2 more reviewers

@hdelan hdelan hdelan left review comments

@EwanC EwanC EwanC approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci/cd Continuous integration/devliery command-buffer Command Buffer feature addition/changes/specification conformance Conformance test suite issues. cuda CUDA adapter specific issues experimental Experimental feature additions/changes/specification hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug native-cpu Native CPU adapter specific issues opencl OpenCL adapter specific issues specification Changes or additions to the specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nrspruit @pbalcer @martygrant @EwanC @hdelan @yingcong-wu