Enable creation of bindless images backed by host USM #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DBDuncan
approved these changes
Jan 13, 2025
GeorgeWeb
approved these changes
Jan 14, 2025
przemektmalon
force-pushed
the
przemek/bindless-images-host-usm
branch
from
7005365 to
d49c8cd
Compare
|
I've removed ready to merge as intel/llvm#16607 still requires approvals (except from unified-runtime-reviewers) and must have all checks passing. Please add the lable again once these conditions are satisfied. |
przemektmalon
force-pushed
the
przemek/bindless-images-host-usm
branch
3 times, most recently
from
01c0c0e to
38da1bd
Compare
Small patch to enable bindless images backed by host USM in the CUDA adapter. Host and Device USM pointers are usable across the host and device for all versions of CUDA that we support. There is no need to provide the `CU_MEMHOSTALLOC_DEVICEMAP` flag during allocation, or calling `cuMemHostGetDevicePointer` to retrieve a device usable address. Passing a `CU_MEMHOSTALLOC_WRITECOMBINED` flag to the host USM allocation will enhance performance in certain scenarios, however, an extension allowing this is not yet available.
przemektmalon
force-pushed
the
przemek/bindless-images-host-usm
branch
from
38da1bd to
eeff9f4
Compare
|
Added ready to merge label. |
dm-vodopyanov
pushed a commit
to intel/llvm
that referenced
this pull request
Jan 27, 2025
This patch adds a test for an image backed by a host USM allocation. Related UR PR: oneapi-src/unified-runtime#2551
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small patch to enable bindless images backed by host USM in the CUDA adapter.
Host and Device USM pointers are usable across the host and device for all versions of CUDA that we support. There is no need to provide the
CU_MEMHOSTALLOC_DEVICEMAPflag during allocation, or callingcuMemHostGetDevicePointerto retrieve a device usable address.Passing a
CU_MEMHOSTALLOC_WRITECOMBINEDflag to the host USM allocation will enhance performance in certain scenarios, however, an extension allowing this is not yet available.Related DPC++ PR: intel/llvm#16607